Remove deprecated trim package dependency#2712
Remove deprecated trim package dependency#2712FenPWysocki wants to merge 5 commits intoauth0:masterfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2712 +/- ##
==========================================
+ Coverage 42.54% 43.52% +0.97%
==========================================
Files 120 120
Lines 3145 3180 +35
Branches 337 339 +2
==========================================
+ Hits 1338 1384 +46
+ Misses 1713 1701 -12
- Partials 94 95 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@FenPWysocki , I have reviewed these changes and it looks good to me. |
|
Hi, @ankita10119 , I don't know how to do it. Can you help? Usually auth0 team automatically merged my Pull Request themselves. |
|
@FenPWysocki , you can read on commit signing here, and learn why it could be useful to configure and how to do so. |
|
Hi! Thanks for the guidance. I’m not very familiar with commit signing / GPG/SSH verification, and this is a bit too complex for me at the moment. |
4 participants
Changes
Removes the deprecated
trim@1.0.1npm package and replaces all usages with the nativeString.prototype.trim()method.trimfrom dependencies in package.jsontrim()function calls with.trim()method across source files:References
Resolves npm deprecation warning:
npm warn deprecated trim@1.0.1: Use String.prototype.trim() insteadTesting
String.prototype.trim()is a native, widely-supported browser APIChecklist